Repository navigation
fix(server): watch_pull_request says when checks already passed - #40866
Conversation
…says so Repro for #40855: the start read sees passing checks, the baseline read records them silently, and the result never mentions it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A watch started on a PR whose checks already pass never wakes for them, yet the tool told the agent to end its turn. setWatching now returns the start read's checksState, and the MCP result adds a next note when it is passing so the agent acts instead of waiting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
**v0.1.12-nightly.20261122.5111** · 30 changes from 10 contributors - **Multi-file diffs.** Open diff now shows every file in a multi-file Codex patch. - **Mixed-content paste.** Pasting a message with text and a picture now keeps both. - **Queued attachments.** Edit a queued message without losing its image or file attachment chips. - **Pull request checks.** Agents watching a pull request can recognize checks that already passed instead of waiting indefinitely. - **Notebook outputs.** Saved HTML outputs now appear when you scroll them into view. ### Plus 24 more bug fixes and performance improvements. <details> <summary>Full changelog</summary> ## What's Changed * perf(mobile): keep image bytes outside draft JSON by @t3dotgg in pingdotgg/t3code#9727 * fix(server): watch_pull_request says when checks already passed by @juliusmarminge in pingdotgg/t3code#40866 * fix(codex): Open diff shows every file of a multi-file patch by @Abhiram-745 in pingdotgg/t3code#40874 * fix(server): ACP startup gives up when the agent never answers the handshake by @juliusmarminge in pingdotgg/t3code#40864 * fix(server): a branch prefixed with another remote's name publishes under its full name by @Abhiram-745 in pingdotgg/t3code#40877 * fix(server): list open delegated tasks when task_status or task_cancel finds no match by @Project516 in pingdotgg/t3code#40886 * fix(gitlab): find merge requests opened from a fork by @Abhiram-745 in pingdotgg/t3code#40894 * fix(web): pasting a chat message with text and a picture keeps both by @juliusmarminge in pingdotgg/t3code#40909 * fix(antigravity): bound silent post-settle background command holds by @Lokkuchakreshkumar in pingdotgg/t3code#40858 * fix(desktop): WSL is not offered or started when only the Windows install stub exists by @juliusmarminge in pingdotgg/t3code#40918 * fix(server): idle /ws connections behind a reverse proxy no longer drop every 60s by @juliusmarminge in pingdotgg/t3code#40932 * fix(server): thread reads no longer attribute T3 Code's compact-before-send /compact to the user by @juliusmarminge in pingdotgg/t3code#40934 * fix(web,mobile): @-file mentions show by name in message previews, not as raw links by @tiliakoos in pingdotgg/t3code#40924 * fix(web): tool calls stay grouped after a usage-limit pause again by @matthew-waters in pingdotgg/t3code#40905 * fix(server): t3 doctor no longer reports a database just under 1 GiB as "1024.0 MiB" by @tiliakoos in pingdotgg/t3code#40952 * fix(web): show clone failure after progress is dismissed by @StiensWout in pingdotgg/t3code#40951 * Invalidate pending theme imports when a replacement is too large by @StiensWout in pingdotgg/t3code#40965 * fix(mobile): show linked thread history page errors by @StiensWout in pingdotgg/t3code#40973 * fix(client-runtime): skip waiting for lower-priority linked addresses by @StiensWout in pingdotgg/t3code#40989 * fix(web): navigate Excel sheets from the focused tab by @StiensWout in pingdotgg/t3code#41008 * fix(mobile): bound app-owned composer attachment filenames by @StiensWout in pingdotgg/t3code#40991 * fix(web): prioritize visible saved notebook outputs by @StiensWout in pingdotgg/t3code#40998 * fix(web): editing a queued message keeps its attachment chips resolved by @smirea in pingdotgg/t3code#40945 * fix(server): unlinking an environment ends its session on the other machine by @juliusmarminge in pingdotgg/t3code#41005 * fix(mobile): scope Git result banners to their originating thread by @StiensWout in pingdotgg/t3code#41015 * fix(web): keep the conversation when a pairing tab closes by @StiensWout in pingdotgg/t3code#41025 * fix: restart linked thread reads when trying again by @StiensWout in pingdotgg/t3code#41020 * fix(client-runtime): count ambiguous projects in chat file links by @StiensWout in pingdotgg/t3code#40986 * fix(mobile): keep media actions on each sent image page by @StiensWout in pingdotgg/t3code#41018 * perf(server): a run's provider turn lookup is linear, not quadratic by @navidnadali in pingdotgg/t3code#38791 ## New Contributors * @Lokkuchakreshkumar made their first contribution in pingdotgg/t3code#40858 * @matthew-waters made their first contribution in pingdotgg/t3code#40905 **Full Changelog**: pingdotgg/t3code@v0.1.12-nightly.20261122.5098...v0.1.12-nightly.20261122.5111 </details> Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.12-nightly.20261122.5111
When an agent started watching a pull request whose checks had already passed,
watch_pull_requestdidn't say so. The watch never wakes for checks that passed before it started, and the tool tells the agent to end its turn, so the agent sat waiting on a green PR. The result now reports the check state seen when the watch started, and tells the agent to act now when checks already pass.PullRequestWatchService.setWatchingreturns thechecksStatefrom the read it already does when a watch starts.WatchPullRequestResultgains an optionalchecksState. When it ispassing, the result adds anextnote saying no wake will come for those checks.Fixes #40855
Reproduction on main
Commit b23f1e8 (origin/main). Ran an isolated server (
t3 serve --base-dir <scratch> --port 38555, fresh database) with a tiny git project whose origin is pingdotgg/t3code, and the OpenCode provider enabled. PR #40645 was open with all 35 check runs completed and none failing. At 13:31:10 UTC:t3 thread start --provider opencode --model opencode/big-pickle --wait . "Call the T3 tool watch_pull_request with url https://github.com/pingdotgg/t3code/pull/40645 ...". The tool returned {"host":"github.com","repository":"pingdotgg/t3code","number":40645,"url":"…/pull/40645","watching":true,"wasWatching":false}, with no check state. Stored events: 13:31:22 thread.pull-request-synced (watch started, awaitingBaseline 'all'); 13:31:26 thread.pull-request-link-updated with headSha e66b677, passed: true, passedChecks of all 8 checks, checksPending: false, wakes: 0, awaitingBaseline cleared. Waited through two sweeps to 13:36:57: no further pull-request events,t3 thread showstill reports runCount 1, watching true and a pending 'Watching pull request #40645' monitor. So the thread was never woken. Unit repro: the new test in apps/server/src/pullRequest/PullRequestWatchService.test.ts fails on main because setWatching's result has no checksState when the start read sees 'passing'.Evidence
Started isolated real servers on both commits with synthetic projects and OpenCode. Called
watch_pull_requeston #40645, whose 35 checks were completed without failures. Base omitted the already-passing state and stored it as the baseline with zero wakes. Head immediately returnedchecksState: "passing"and told the agent no wake would come for those checks. Real OpenCode turns reported the same respective results.Reproduction and capture drivers. Captures show real terminal output, not web UI. Both use Linux, isolated state, identical viewport and theme. The longer base observation was interrupted by a server stop and resumed after restart; it does not establish an uninterrupted six-minute wait.
Not shown:
Tests
vp test run src/pullRequest/PullRequestWatchService.test.ts src/mcp/McpHttpServer.test.ts(apps/server): 49 passedvp run typecheck(apps/server): exit 0vp run check:changed: format, lint, knip, graphql, typecheck (3 packages) and tests (3 files) passNot in this change
until: "checks"on a PR whose checks already pass stays registered rather than ending at once; changing that is a behaviour change beyond reporting the state.nextnote; the result'snextoverrides it per call.nextnote and was not run.Who did the work
Run by the t3code factory in T3 Code.